refactor!: remove the tableid in ddl response since tableids is enough #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
approved these changes
May 31, 2024
fengjiachun
force-pushed
the
refactor/remove-table-id-in-ddl-resp
branch
from
b9d9ad0
to
81a22ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4080 +/- ##
==========================================
- Coverage 85.53% 85.23% -0.31%
==========================================
Files 991 991
Lines 172933 172929 -4
==========================================
- Hits 147925 147391 -534
- Misses 25008 25538 +530 |
fengjiachun
changed the title
github-actions
bot
added
the
breaking-change
evenyag
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As the title said, we do not need
table idany more,table idsis enough, the PR of proto is: GreptimeTeam/greptime-proto#175Checklist