-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flow): mfp operator missing rows #4084
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4084 +/- ##
==========================================
- Coverage 85.49% 85.17% -0.33%
==========================================
Files 991 991
Lines 173091 173142 +51
==========================================
- Hits 147988 147477 -511
- Misses 25103 25665 +562 |
Can we test it? |
Unit test are added, but since this bug is not quite yet suitable to be tested using sqlness/tests-intergation crate because it require above certain qps to be triggered, is considering modify tsbs or add a extra script/repo to test it |
flow doesn't work real well with sqlness since it's kind of async-ish, and can't update to dest table fast enough before sqlness deem test are done, currently working on that, meanwhile I'm using a python script to locally test flow's functionality |
ac0af01
to
53a7b55
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
fix a bug that mfp operator will missing rows if run multiple tims in same tick
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist