Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Display for PartitionExpr #4087

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

Kelvinyu1117
Copy link
Contributor

@Kelvinyu1117 Kelvinyu1117 commented Jun 2, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

This closes #3985 .

What's changed and what's your intention?

!!! DO NOT LEAVE THIS BLOCK EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@Kelvinyu1117 Kelvinyu1117 requested a review from a team as a code owner June 2, 2024 03:41
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 2, 2024
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I have a suggestion to write the test in a more tidy way:

let cases = [
  (Operand::Column(..), RestrictedOp::.., Operand::Column(..), "a = b"),
  ...
]

or even pack the input and output into a temporary struct,

This patch itself is good to merge.

Thanks for your contribution!

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (c2218f8) to head (38f9856).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4087      +/-   ##
==========================================
- Coverage   85.49%   85.19%   -0.30%     
==========================================
  Files         991      991              
  Lines      172968   173053      +85     
==========================================
- Hits       147878   147437     -441     
- Misses      25090    25616     +526     

@Kelvinyu1117
Copy link
Contributor Author

Although I have a suggestion to write the test in a more tidy way:

let cases = [
  (Operand::Column(..), RestrictedOp::.., Operand::Column(..), "a = b"),
  ...
]

or even pack the input and output into a temporary struct,

This patch itself is good to merge.

Thanks for your contribution!

Thanks, updated.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@killme2008 killme2008 added this pull request to the merge queue Jun 2, 2024
Merged via the queue into GreptimeTeam:main with commit 88cdefa Jun 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implements Display for PartitionExpr
3 participants