-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix EntityTooSmall issue #4100
Conversation
6aed083
to
e1259b2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4100 +/- ##
==========================================
- Coverage 85.47% 85.18% -0.30%
==========================================
Files 991 991
Lines 173053 173151 +98
==========================================
- Hits 147920 147491 -429
- Misses 25133 25660 +527 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe elaborate the reason why the entity will be 256KB if |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
We rely on the
BufferedWriter
to avoid writing too small entities to S3 directly. However, theinto_futures_async_write
will break this feature(it introduces another buffer in the underlying writer). And consider simplifying theBufferredWriter
in the future.EntityTooSmall
error issuesChecklist