Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix EntityTooSmall issue #4100

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 3, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

We rely on the BufferedWriter to avoid writing too small entities to S3 directly. However, the into_futures_async_write will break this feature(it introduces another buffer in the underlying writer). And consider simplifying the BufferredWriter in the future.

  1. fix S3 returns EntityTooSmall error issues
  2. Add a unit test for this case.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 3, 2024
@WenyXu WenyXu mentioned this pull request Jun 3, 2024
3 tasks
@WenyXu WenyXu marked this pull request as ready for review June 4, 2024 04:28
@WenyXu WenyXu requested review from evenyag, v0y4g3r, waynexia and a team as code owners June 4, 2024 04:28
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (4e5dd1e) to head (e1259b2).
Report is 2 commits behind head on main.

Current head e1259b2 differs from pull request most recent head 1a28c48

Please upload reports for the commit 1a28c48 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4100      +/-   ##
==========================================
- Coverage   85.47%   85.18%   -0.30%     
==========================================
  Files         991      991              
  Lines      173053   173151      +98     
==========================================
- Hits       147920   147491     -429     
- Misses      25133    25660     +527     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r
Copy link
Contributor

v0y4g3r commented Jun 4, 2024

Maybe elaborate the reason why the entity will be 256KB if chunk parameter is not provided in the pr detail.

.github/workflows/develop.yml Show resolved Hide resolved
src/mito2/src/sst/parquet/writer.rs Outdated Show resolved Hide resolved
.github/workflows/develop.yml Show resolved Hide resolved
@WenyXu WenyXu added this pull request to the merge queue Jun 4, 2024
Merged via the queue into GreptimeTeam:main with commit a626939 Jun 4, 2024
27 checks passed
@WenyXu WenyXu deleted the fix/entity-too-small branch June 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants