Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recover memtable options when opening physical regions #4102

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Jun 4, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

During creating physical regions for metric engine, index and memtable options are set manually:

set_index_options_for_data_region(&mut data_region_request.options);
// Set memtable options.
set_memtable_options_for_data_region(&mut data_region_request.options);

But when open physical regions, only index options are set:

set_index_options_for_data_region(&mut data_region_options);

Memory usage

image

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@v0y4g3r v0y4g3r requested a review from waynexia as a code owner June 4, 2024 07:29
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 4, 2024
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core tech ⚡

@v0y4g3r v0y4g3r requested review from evenyag and WenyXu June 4, 2024 07:34
@evenyag evenyag added this pull request to the merge queue Jun 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2024
* fix: recover memtable options when opening physical regions

* chore: fmt
@evenyag evenyag removed this pull request from the merge queue due to a manual request Jun 4, 2024
@v0y4g3r v0y4g3r requested a review from fengjiachun June 4, 2024 08:03
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r enabled auto-merge June 4, 2024 08:07
@v0y4g3r v0y4g3r added this pull request to the merge queue Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (d1838fb) to head (69de0e8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4102      +/-   ##
==========================================
- Coverage   85.49%   85.17%   -0.33%     
==========================================
  Files         991      991              
  Lines      173091   173087       -4     
==========================================
- Hits       147988   147420     -568     
- Misses      25103    25667     +564     

Merged via the queue into GreptimeTeam:main with commit a80059b Jun 4, 2024
28 checks passed
@v0y4g3r v0y4g3r deleted the fix/recover-memtable-options-for-metric-engine branch June 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants