Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invoke handle_batch_open_requests #4107

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 5, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #4026

What's changed and what's your intention?

Via invoking handle_batch_open_requests, which allows the database to read the WAL entries once, to open all regions sharing the same WAL topic.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 5, 2024
@WenyXu WenyXu force-pushed the feat/batch-open-regions-region-server branch from fabb53e to a10a196 Compare June 6, 2024 03:40
@WenyXu WenyXu force-pushed the feat/batch-open-regions-region-server branch from a10a196 to 4fa766b Compare June 6, 2024 03:46
@WenyXu WenyXu marked this pull request as ready for review June 6, 2024 04:43
@WenyXu WenyXu requested a review from a team as a code owner June 6, 2024 04:43
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 78.62595% with 28 lines in your changes missing coverage. Please review.

Project coverage is 85.13%. Comparing base (c23f8ad) to head (c0771ac).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4107      +/-   ##
==========================================
- Coverage   85.46%   85.13%   -0.34%     
==========================================
  Files         993      994       +1     
  Lines      173751   174093     +342     
==========================================
- Hits       148495   148210     -285     
- Misses      25256    25883     +627     

src/datanode/src/datanode.rs Outdated Show resolved Hide resolved
src/datanode/src/datanode.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will definitely be LGTM

src/datanode/src/region_server.rs Outdated Show resolved Hide resolved
src/datanode/src/region_server.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/batch-open-regions-region-server branch from d6f1622 to 77728f0 Compare June 7, 2024 03:27
@WenyXu WenyXu requested a review from evenyag June 7, 2024 07:02
src/datanode/src/region_server.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu enabled auto-merge June 7, 2024 08:53
@WenyXu WenyXu added this pull request to the merge queue Jun 7, 2024
Merged via the queue into GreptimeTeam:main with commit e142ca4 Jun 7, 2024
52 checks passed
@WenyXu WenyXu deleted the feat/batch-open-regions-region-server branch June 7, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking issue] open regions in batches
3 participants