-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: invoke handle_batch_open_requests
#4107
Merged
WenyXu
merged 6 commits into
GreptimeTeam:main
from
WenyXu:feat/batch-open-regions-region-server
Jun 7, 2024
Merged
feat: invoke handle_batch_open_requests
#4107
WenyXu
merged 6 commits into
GreptimeTeam:main
from
WenyXu:feat/batch-open-regions-region-server
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabb53e
to
a10a196
Compare
a10a196
to
4fa766b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4107 +/- ##
==========================================
- Coverage 85.46% 85.13% -0.34%
==========================================
Files 993 994 +1
Lines 173751 174093 +342
==========================================
- Hits 148495 148210 -285
- Misses 25256 25883 +627 |
fengjiachun
reviewed
Jun 6, 2024
fengjiachun
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will definitely be LGTM
evenyag
reviewed
Jun 7, 2024
d6f1622
to
77728f0
Compare
7 tasks
evenyag
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #4026
What's changed and what's your intention?
Via invoking
handle_batch_open_requests,
which allows the database to read the WAL entries once, to open all regions sharing the same WAL topic.Checklist