Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry on unknown error #4138

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 13, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

It should retry on unknown error (e.g. incurring transport error)

2024-06-10T05:01:57.684978Z ERROR LocalManager::submit_root_procedure: common_procedure::local::runner: Failed to execute procedure metasrv-procedure::DropTable-4d04bd3d-3a0f-495c-819d-80b939475fa4, retry: false err=0: Failed to execute procedure due to external error
2024-06-10 13:01:57.685	
1: Failed to operate on datanode: peer-2(greptimedb-datanode-2.greptimedb-datanode.greptimedb:4001), at greptimedb/src/common/meta/src/ddl/utils.rs:33:27
2024-06-10 13:01:57.685	
2: External error, at greptimedb/src/client/src/region.rs:59:31
2024-06-10 13:01:57.685	
3: Failed to request RegionServer greptimedb-datanode-2.greptimedb-datanode.greptimedb:4001, code: Unknown error, at greptimedb/src/client/src/region.rs:193:31
2024-06-10 13:01:57.685	
4: transport error, at greptimedb/src/client/src/error.rs:176:23

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 13, 2024
@WenyXu WenyXu marked this pull request as ready for review June 13, 2024 07:42
@WenyXu WenyXu requested a review from a team as a code owner June 13, 2024 07:43
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (14a2d83) to head (d7af44a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4138      +/-   ##
==========================================
- Coverage   85.47%   85.17%   -0.31%     
==========================================
  Files         994      994              
  Lines      174942   174942              
==========================================
- Hits       149535   149001     -534     
- Misses      25407    25941     +534     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Jun 13, 2024
Merged via the queue into GreptimeTeam:main with commit 1f315e3 Jun 13, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants