Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce chaos crds #4173

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat: introduce chaos crds #4173

merged 1 commit into from
Jun 21, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 19, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Introduce the chaos-mesh CRDs (Custom Resource Definition) for e2e fuzz tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 19, 2024
@WenyXu WenyXu marked this pull request as ready for review June 20, 2024 06:31
@WenyXu WenyXu requested a review from a team as a code owner June 20, 2024 06:31
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.81%. Comparing base (cc2f7ef) to head (0a7cfa0).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4173      +/-   ##
==========================================
- Coverage   85.12%   84.81%   -0.32%     
==========================================
  Files        1020     1024       +4     
  Lines      179635   179894     +259     
==========================================
- Hits       152920   152579     -341     
- Misses      26715    27315     +600

fengjiachun
fengjiachun approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

waynexia
waynexia reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't look just believe.

BTW, how would this be used?

@WenyXu WenyXu added this pull request to the merge queue Jun 21, 2024
Merged via the queue into GreptimeTeam:main with commit 1e52ba3 Jun 21, 2024
49 checks passed
@WenyXu WenyXu deleted the feat/chaos-crds branch June 21, 2024 06:51
zyy17 pushed a commit to zyy17/greptimedb that referenced this pull request Jun 22, 2024
@WenyXu @zyy17
feat: introduce chaos crds (GreptimeTeam#4173)
1e4a370 
feat: add chaos-mesh crds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WenyXu @fengjiachun @waynexia