Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deregister table for MemoryCatalogManager #620

Merged
merged 8 commits into from
Nov 24, 2022

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • API change Add memory_catalog_enable option to standalone start command
  • Add new method deregister_table to trait CatalogManager
  • Implement deregister_table for MemoryCatalogManager

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Part of #497, also related to #614

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia changed the title Memory catalog drop table feat: deregister table for MemoryCatalogManager Nov 22, 2022
src/catalog/src/local/manager.rs Outdated Show resolved Hide resolved
src/catalog/src/lib.rs Outdated Show resolved Hide resolved
src/catalog/src/lib.rs Outdated Show resolved Hide resolved
src/catalog/src/lib.rs Outdated Show resolved Hide resolved
src/catalog/src/lib.rs Outdated Show resolved Hide resolved
src/catalog/src/local/memory.rs Outdated Show resolved Hide resolved
src/catalog/src/remote/manager.rs Outdated Show resolved Hide resolved
src/cmd/src/standalone.rs Outdated Show resolved Hide resolved
src/datanode/src/datanode.rs Outdated Show resolved Hide resolved
src/catalog/src/local/memory.rs Outdated Show resolved Hide resolved
src/catalog/src/local/memory.rs Show resolved Hide resolved
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #620 (00cd5ec) into develop (9f865b5) will decrease coverage by 0.07%.
The diff coverage is 52.77%.

@@             Coverage Diff             @@
##           develop     #620      +/-   ##
===========================================
- Coverage    86.35%   86.28%   -0.08%     
===========================================
  Files          401      402       +1     
  Lines        50769    50973     +204     
===========================================
+ Hits         43843    43982     +139     
- Misses        6926     6991      +65     
Flag Coverage Δ
rust 86.28% <52.77%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/catalog/src/lib.rs 81.81% <0.00%> (-1.91%) ⬇️
src/datanode/src/instance.rs 35.25% <0.00%> (+0.18%) ⬆️
src/frontend/src/catalog.rs 6.76% <0.00%> (-0.10%) ⬇️
src/cmd/src/standalone.rs 37.71% <16.66%> (-0.53%) ⬇️
src/catalog/src/local/manager.rs 65.17% <40.00%> (-1.19%) ⬇️
src/catalog/src/remote/manager.rs 69.35% <40.00%> (-0.70%) ⬇️
src/catalog/src/error.rs 83.33% <50.00%> (-0.88%) ⬇️
src/catalog/src/local/memory.rs 82.82% <90.19%> (+10.13%) ⬆️
src/datanode/src/datanode.rs 53.84% <100.00%> (+1.21%) ⬆️
src/servers/src/error.rs 27.02% <0.00%> (-16.22%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 7b37e99 into GreptimeTeam:develop Nov 24, 2022
@waynexia waynexia deleted the memory-catalog-drop-table branch November 24, 2022 03:36
@waynexia waynexia mentioned this pull request Nov 24, 2022
7 tasks
@waynexia waynexia added the docs-required This change requires docs update. label Nov 29, 2022
@sunng87 sunng87 added docs-required This change requires docs update. and removed docs-required This change requires docs update. labels Dec 9, 2022
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants