-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove optional from the protos #756
refactor: remove optional from the protos #756
Conversation
3dd2749
to
0ab3e5c
Compare
4edf346
to
d1f6abe
Compare
ff49646
to
404ef38
Compare
Codecov Report
@@ Coverage Diff @@
## develop #756 +/- ##
===========================================
+ Coverage 85.39% 85.43% +0.03%
===========================================
Files 413 413
Lines 54142 54165 +23
===========================================
+ Hits 46237 46278 +41
+ Misses 7905 7887 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Remove
optional
from protos, because theoptional
relies on a higher version of proto (supported in 3.15.0), which often causes some problems for users, e.g. (#616 #737 ), and I think we can avoid using this feature.Checklist
Refer to a related PR or issue link (optional)
#616 #737