Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor the 'install.sh' and release to aws-cn s3 bucket #132

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Aug 22, 2023

What's changed

  1. Support to download from aws-cn bucket, for example:

    ./hack/install.sh -s aws
    
  2. Support to verify sha256;

  3. Support to install the gtctl to system path if set -i option;

  4. Add manually triggered github action to release script to aws-cn S3 bucket;

1. Support to download from aws-cn bucket;
2. Support to verify sha256;

Signed-off-by: zyy17 <zyylsxm@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #132 (fe5f63d) into develop (294be69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #132   +/-   ##
========================================
  Coverage    21.94%   21.94%           
========================================
  Files            8        8           
  Lines          948      948           
========================================
  Hits           208      208           
  Misses         683      683           
  Partials        57       57           

@daviderli614
Copy link
Member

daviderli614 commented Aug 22, 2023

CI failed @zyy17

@zyy17
Copy link
Collaborator Author

zyy17 commented Aug 23, 2023

@daviderli614 Seems OK after retry.

Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawnh2 shawnh2 merged commit 2a728f2 into GreptimeTeam:develop Aug 24, 2023
6 checks passed
@zyy17 zyy17 deleted the chore/refine-install-script branch August 24, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants