Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create new context for bare-metal deployer #148

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Sep 18, 2023

for bare-metal mode, deployment and operation are using the same ctx, causing the running binaries to shutdown if we pass the value to --timeout.

so the fix here is: separate the ctx of deployment and operation, do not let --timeout disturb the running binaries.

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from zyy17 September 18, 2023 08:31
Signed-off-by: sh2 <shawnhxh@outlook.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.15% 🎉

Comparison is base (6366341) 31.86% compared to head (99095fd) 32.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #148      +/-   ##
===========================================
+ Coverage    31.86%   32.02%   +0.15%     
===========================================
  Files            9        9              
  Lines         1293     1296       +3     
===========================================
+ Hits           412      415       +3     
  Misses         787      787              
  Partials        94       94              
Files Changed Coverage Δ
pkg/cmd/gtctl/cluster/create/create.go 0.00% <0.00%> (ø)
pkg/deployer/baremetal/deployer.go 35.86% <37.50%> (+0.70%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyy17 zyy17 merged commit 1cd3b44 into GreptimeTeam:develop Sep 19, 2023
6 checks passed
@shawnh2 shawnh2 deleted the fix-install-ctx branch September 19, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants