Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement config setup for each component in bare-metal mode #153

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Sep 20, 2023

@shawnh2 shawnh2 requested a review from zyy17 September 20, 2023 09:47
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 29.90% and project coverage change: -0.38% ⚠️

Comparison is base (1cd3b44) 32.02% compared to head (49d82ef) 31.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
- Coverage    32.02%   31.64%   -0.38%     
===========================================
  Files            9       11       +2     
  Lines         1296     1384      +88     
===========================================
+ Hits           415      438      +23     
- Misses         787      839      +52     
- Partials        94      107      +13     
Files Changed Coverage Δ
pkg/cmd/gtctl/cluster/create/create.go 0.00% <0.00%> (ø)
pkg/deployer/baremetal/deployer.go 33.44% <8.00%> (-2.43%) ⬇️
pkg/deployer/baremetal/config.go 33.33% <33.33%> (ø)
pkg/utils/file/yaml.go 47.82% <47.82%> (ø)
pkg/deployer/baremetal/validate.go 80.00% <100.00%> (-4.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sh2 <shawnhxh@outlook.com>
…l mode

Signed-off-by: sh2 <shawnhxh@outlook.com>
@MichaelScofield MichaelScofield merged commit 4394eab into GreptimeTeam:develop Sep 22, 2023
6 checks passed
@shawnh2 shawnh2 deleted the bm-com-config branch September 22, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support complete configuration of gretimedb in bare metal mode
3 participants