Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reimplement the create cmd for k8s and bare-metal #177

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Oct 27, 2023

related to: #160, #155, #172

it's a big PR, but it does not introduce anything new, just move the code from an old place to a new place.

some minors in this PR:

this PR blocks:

  • delete cmd refactor
  • connect cmd refactor

Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyy17 zyy17 merged commit 53242c3 into GreptimeTeam:develop Oct 31, 2023
8 checks passed
@shawnh2 shawnh2 deleted the refactor/create-cmd branch October 31, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants