Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reimplement cluster connect cmd #180

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Nov 2, 2023

Closes: #160

Signed-off-by: sh2 <shawnhxh@outlook.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (412ad43) 38.47% compared to head (78bd948) 38.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #180      +/-   ##
===========================================
- Coverage    38.47%   38.21%   -0.27%     
===========================================
  Files           16       16              
  Lines         1276     1285       +9     
===========================================
  Hits           491      491              
- Misses         680      689       +9     
  Partials       105      105              
Files Coverage Δ
pkg/utils/semver/semver.go 40.00% <ø> (ø)
pkg/cluster/baremetal/not_implemented.go 0.00% <0.00%> (ø)
pkg/cluster/baremetal/create.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyy17 zyy17 merged commit 0c4cb58 into GreptimeTeam:develop Nov 3, 2023
6 checks passed
@shawnh2 shawnh2 deleted the refactor/connect-cmd branch November 3, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor tracking: separate gtctl cmd from its implementation logic
3 participants