Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up unused deployer code #182

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Nov 3, 2023

No description provided.

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from zyy17 November 3, 2023 09:47
Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2
Copy link
Contributor Author

shawnh2 commented Nov 5, 2023

ooops, my bad 😢 PTAL @zyy17

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c4cb58) 38.21% compared to head (385e78e) 38.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #182   +/-   ##
========================================
  Coverage    38.21%   38.21%           
========================================
  Files           16       16           
  Lines         1285     1285           
========================================
  Hits           491      491           
  Misses         689      689           
  Partials       105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyy17 zyy17 merged commit 76e265f into GreptimeTeam:develop Nov 6, 2023
6 checks passed
@shawnh2 shawnh2 deleted the rm-deployer branch November 6, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants