It is not the job of the library to enable interrupts. This could cau…

…se a serious race condition in a sketch. See http://gammon.com.au/interrupts, the 'How are interrupts queued?' section.
GreyGnome · Oct 17, 2015 · b199f1f · b199f1f
1 parent 6392087
commit b199f1f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -8,8 +8,9 @@ Functions:
 enableInterrupt- Enables interrupt on a selected Arduino pin.
 disableInterrupt - Disables interrupt on the selected Arduino pin.
 ```
-*_What's New?_ Fri Oct 16 07:52:45 CDT 2015
-Version 0.9.1 of the library has been released. Arduino Zero support added. Bug fixes in examples/OOSimple (thanks RobertClemenzi). And don't forget about the ATtiny support added in 0.9.0! See the Release Notes in the extras directory for details.
+
+*_What's New?_ Sat Oct 17 11:56:01 CDT 2015
+Version 0.9.2 of the library has been released. I discovered a rather pernicious bug, wherein the library was setting the global interrupt enable bit. This could cause a serious and difficult-to-debug race condition, as it is not the job of the library to manage that bit. The chips come with interrupts enabled so existing code should not be affected. My thanks to http://gammon.com.au/interrupts (the 'How are interrupts queued?' section).
 
 The EnableInterrupt library is an Arduino interrupt library, designed for
 all versions of the Arduino- at this writing, the Uno (and other ATmega328p-based

diff --git a/extras/RELEASE_NOTES b/extras/RELEASE_NOTES
@@ -1,3 +1,7 @@
+Sat Oct 17 12:03:03 CDT 2015
+Version 0.9.2. I discovered a rather pernicious bug, wherein the library was setting the global interrupt enable bit. This could cause a serious and difficult-to-debug race condition, as it is not the job of the library to manage that bit. The chips come with interrupts enabled so exi
+sting code should not be affected. My thanks to http://gammon.com.au/interrupts (the 'How are interrupts queued?' section).
+
 Fri Oct 16 07:58:45 CDT 2015
 Version 0.9.1. Bug fixes to examples/OOSimple (thanks RobertClemenzi!). Arduino Zero support added (this is a trivial preprocessor macro check; see the Usage wiki page). Wiki pages updated, especially the FAQ.
 

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=EnableInterrupt
-version=0.9.1
+version=0.9.2
 author=Mike "GreyGnome" Schwager <mschwage@gmail.com>
 maintainer=Mike "GreyGnome" Schwager <mschwage@gmail.com>
 sentence=Assign an interrupt to any supported pin on all Arduinos, plus ATtiny 84/85 and ATmega 644/1284.