Skip to content

Commit

Permalink
beets-alternatives: Disable test suite for now
Browse files Browse the repository at this point in the history
Regression introduced by 9435119.

Running the tests results in the following traceback:
  ...
  File ".../unittest/loader.py", line 91, in loadTestsFromName
    module = __import__('.'.join(parts_copy))
  File ".../test/regrtest.py", line 184, in <module>
    for module in sys.modules.itervalues():
RuntimeError: dictionary changed size during iteration

The reason for this is that the test directory itself is called "test"
and the package including regrtest.py is also called "test", so the
loader tries to load tests from its own implementation.

We could fix this by changing PYTHONPATH and/or making the test
directory a proper package, but we'd still have failing tests because
beets itself is required to run the tests.

However for now I'm just removing the unit_tests kwarg in setup.py so
that we have the same behaviour as before the initially mentioned
commit.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
  • Loading branch information
aszlig committed Sep 2, 2017
1 parent cc44675 commit bd2aeb4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkgs/tools/audio/beets/alternatives-plugin.nix
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ pythonPackages.buildPythonApplication rec {

postPatch = ''
sed -i -e '/install_requires/,/\]/{/beets/d}' setup.py
sed -i -e '/test_suite/d' setup.py
'';

propagatedBuildInputs = with pythonPackages; [ futures ];
Expand Down

0 comments on commit bd2aeb4

Please sign in to comment.