Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for additional csv headers #276

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Adds support for additional csv headers #276

merged 2 commits into from
Sep 27, 2022

Conversation

douglance
Copy link
Contributor

  • In addition to { key, val }, adds support for any combination of the following headers:
    • Name
    • name
    • Key
    • Address
    • address
    • Val
  • Sets default csv export headers to { name, address }

Copy link
Contributor

@alex-miller-0 alex-miller-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the use case here but it seems fine

Comment on lines +23 to +24
name: address.key,
address: address.val,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this search now not case sensitive? I'm confused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is taking the addresses from the Lattice, which are always {key, val} and turning them into {name, address} so users see "name" and "address" as the headers in their CSV file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I was referring to the capitalized keys that show up in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh--yeah, it's just making it a little less case-sensitive. No other functionality in the app should change outside of the CSV headers. The user was having issues with capitalization with the header names.

@douglance douglance merged commit 4a0daad into master Sep 27, 2022
@douglance douglance deleted the dl/headers branch September 27, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants