Adds support for additional csv headers #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-miller-0
approved these changes
Sep 27, 2022
Comment on lines
+23
to
+24
| name: address.key, | ||
| address: address.val, |
There was a problem hiding this comment.
So is this search now not case sensitive? I'm confused
There was a problem hiding this comment.
This is taking the addresses from the Lattice, which are always {key, val} and turning them into {name, address} so users see "name" and "address" as the headers in their CSV file.
There was a problem hiding this comment.
Right, I was referring to the capitalized keys that show up in this PR
There was a problem hiding this comment.
ohhh--yeah, it's just making it a little less case-sensitive. No other functionality in the app should change outside of the CSV headers. The user was having issues with capitalization with the header names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ key, val }, adds support for any combination of the following headers:{ name, address }