New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstall under different service credentials does not overwrite HTTP reservations #70

Open

ritchiecarroll opened this issue Dec 15, 2021 · 2 comments

Labels

bug

Member

ritchiecarroll commented Dec 15, 2021

Further testing shows that original reservations associated with initial service install are not always being removed.

Could be an issue with code call from uninstall operation - perhaps DLL gets removed before call executes reservation removal?

ritchiecarroll added the bug label

Member

StephenCWills commented Dec 15, 2021

Removal occurs during install, right before adding new ones.
https://github.com/GridProtectionAlliance/gsf/blob/fb778cb5c3720775d1329222ffbc24306fe6ca46/Source/Libraries/GSF.InstallerActions/CustomActions.cs#L527-L533

Member

StephenCWills commented Dec 15, 2021

The issue is that it's missing the slash at the end of the URL.
https://github.com/GridProtectionAlliance/gsf/blob/fb778cb5c3720775d1329222ffbc24306fe6ca46/Source/Libraries/GSF.InstallerActions/CustomActions.cs#L919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment