Replace eve.concepts.AnyNode by eve.concepts.BaseNode #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdahm
requested review from
havogt and
egparedes
and removed request for
havogt
jdahm
changed the title
egparedes
requested changes
Dec 6, 2021
| @@ -116,11 +115,10 @@ class Config: | |||
| _EVE_NODE_INTERNAL_SUFFIX = "__" | |||
| _EVE_NODE_IMPL_SUFFIX = "_" | |||
|
|
|||
| AnyNode = TypeVar("AnyNode", bound="BaseNode") | |||
There was a problem hiding this comment.
I'm not sure if we should delete the AnyNode TypeVar definition, since it has a different meaning than BaseNode. Example:
def f1(a: BaseNode) -> BaseNode:
...
def f2(a: AnyNode) -> AnyNode:
...
f2 always returns the same BaseNode subclass it got as an argument, while f1 may return a different subclass. Maybe it could be renamed to NodeT to make clear that is a TypeVar.
|
@egparedes Apologies, I meant to convert this to a draft before I left for the day on Friday. There many cascading type issues that mypy catches that need to be solved first. Your comment might help with that. |
[skip ci]
|
Closing this for inactivity. Will re-examine when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the TypeVar from concepts, which means these can be used in
ClassVarinstances.Resolves #565.