Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue uncovered with new pydantic version, and update pre-commit and hook versions #603

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Fix issue uncovered with new pydantic version, and update pre-commit and hook versions #603

merged 4 commits into from
Jan 6, 2022

Conversation

jdahm
Copy link
Contributor

@jdahm jdahm commented Jan 5, 2022 •
edited
Loading

Description

Updates pydantic and a few pre-commit hook libraries, but does not unpin python 3.9 because that triggers another issue.

@jdahm jdahm requested a review from havogt January 5, 2022 19:31
@jdahm jdahm changed the title Update pydantic, unpin py39, update pre-commit hook versions Update pydantic, update pre-commit hook versions Jan 5, 2022
@jdahm jdahm changed the title Update pydantic, update pre-commit hook versions Update pydantic and pre-commit hook versions Jan 5, 2022
@jdahm
Copy link
Contributor Author

jdahm commented Jan 6, 2022

@egparedes @havogt I thought we could remove the pin in gt4py-tox.yml to allow later versions of 3.9 but doing so causes a check in the standard library's typing.py to catch (what I think is) a design issue in eve.

@jdahm jdahm changed the title Update pydantic and pre-commit hook versions Fix issue uncovered with new pydantic version, and update pre-commit and hook versions Jan 6, 2022
egparedes
egparedes approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@havogt
Copy link
Contributor

havogt commented Jan 6, 2022

bors try

bors bot added a commit that referenced this pull request Jan 6, 2022
@bors
Try #603:
e41299e
@havogt havogt merged commit e20e23e into GridTools:master Jan 6, 2022
@havogt havogt deleted the update-pydantic branch January 6, 2022 13:22
@bors
Copy link

bors bot commented Jan 6, 2022

try

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

@havogt havogt havogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdahm @havogt @egparedes