Adds support for opt_archive parameter in pp_ser.py Python preprocessor #14
Conversation
|
Sorry, I have never worked with the preprocessor, so I had no idea about that. |
| @@ -75,17 +76,17 @@ SUBROUTINE ppser_initialize(directory, prefix, mode, prefix_ref, mpi_rank, rprec | |||
| IF ( .NOT. ppser_initialized ) THEN | |||
| IF ( PRESENT(mpi_rank) ) THEN | |||
| WRITE(suffix, '(A5,I0)') "_rank", mpi_rank | |||
| CALL fs_create_serializer(directory, TRIM(prefix)//TRIM(suffix), 'w', ppser_serializer) | |||
| CALL fs_create_serializer(directory, TRIM(prefix)//TRIM(suffix), 'w', ppser_serializer, opt_archive) | |||
There was a problem hiding this comment.
Should use a conditional with PRESENT otherwise execution will failed when opt_archive is not passed.
There was a problem hiding this comment.
Sorry, i think you are wrong. When an non-present optional argument is passed to another routine which also declares this argument as optional, the argument will also just be not present in the called routine. So, I'm pretty sure that you don't need an IF (PRESENT(opt_archive)) here, but haven't double-checked it.
| ELSE | ||
| CALL fs_create_serializer(directory, TRIM(prefix), 'w', ppser_serializer) | ||
| CALL fs_create_serializer(directory, TRIM(prefix), 'w', ppser_serializer, opt_archive) |
There was a problem hiding this comment.
Same as previous comment
| END IF | ||
| CALL fs_create_savepoint('', ppser_savepoint) | ||
| IF ( PRESENT(mode) ) ppser_mode = mode | ||
| IF ( PRESENT(prefix_ref) ) THEN | ||
| IF ( PRESENT(mpi_rank) ) THEN | ||
| CALL fs_create_serializer(directory, TRIM(prefix_ref)//TRIM(suffix), 'r', ppser_serializer_ref) | ||
| CALL fs_create_serializer(directory, TRIM(prefix_ref)//TRIM(suffix), 'r', ppser_serializer_ref, opt_archive) |
There was a problem hiding this comment.
Same as previous comment
| ELSE | ||
| CALL fs_create_serializer(directory, TRIM(prefix_ref), 'r', ppser_serializer_ref) | ||
| CALL fs_create_serializer(directory, TRIM(prefix_ref), 'r', ppser_serializer_ref, opt_archive) |
There was a problem hiding this comment.
Same as previous comment
|
Thank you for your detailed review. I hope my update fixes the problem. |
|
Hmm... It compiles on my machine... |
|
OK. I've got the error. Still don't know how on earth did it compiled fine on my machine... |
|
Can you also rename |
There was a problem hiding this comment.
Sorry, wasn't able to answer earlier. I think the inserted IFs were not necessary. See my comment on @clementval's review.
| @@ -75,17 +76,17 @@ SUBROUTINE ppser_initialize(directory, prefix, mode, prefix_ref, mpi_rank, rprec | |||
| IF ( .NOT. ppser_initialized ) THEN | |||
| IF ( PRESENT(mpi_rank) ) THEN | |||
| WRITE(suffix, '(A5,I0)') "_rank", mpi_rank | |||
| CALL fs_create_serializer(directory, TRIM(prefix)//TRIM(suffix), 'w', ppser_serializer) | |||
| CALL fs_create_serializer(directory, TRIM(prefix)//TRIM(suffix), 'w', ppser_serializer, opt_archive) | |||
There was a problem hiding this comment.
Sorry, i think you are wrong. When an non-present optional argument is passed to another routine which also declares this argument as optional, the argument will also just be not present in the called routine. So, I'm pretty sure that you don't need an IF (PRESENT(opt_archive)) here, but haven't double-checked it.
|
Whats the status here? Can we merge it? |
|
All happy @clementval @pspoerri ? |
This item was missing after @chovyy 's fix. I named the parameter the same as in the called function,
opt_archivewhich might not be the best name, because most parameters passed by pp_ser.py are optional.(This is my first ever public PR in Fortran ;-) ).