Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row events #64

Closed
wavded opened this issue Jan 31, 2015 · 7 comments
Closed

Row events #64

wavded opened this issue Jan 31, 2015 · 7 comments

Comments

@wavded
Copy link

wavded commented Jan 31, 2015

Apologies if I missed this in the documentation but I'd like a way to have events when rows are interacted with. Namely if they are clicked or hovered over. Is this doable? Thanks!

@ryanlanciaux
Copy link
Member

Thanks for posting this! Currently this isn't something that can be done easily but we are adding some ways to easily have events on these items.

@hc000
Copy link

hc000 commented Feb 24, 2015

I was playing around with this and I used the useCustomRowComponent and customRowComponent to add another component (and add the event in the other components).

However it removed the default formatting (column header and spacings) of the original table.

Any suggestions on how to go about and integrate them together?

var Popup2 = React.createClass({
getDefaultProps: function(){
return { "data": {} };
},
showSimpleDialog: function(e){
this.refs.simpleDialog.show();
},
render:function(){
return (


{this.props.data}


I'm a popup!


)
}
});

@rorykoehein
Copy link
Contributor

I've currently added an 'onRowClick' prop to Griddle, and then pass that down to gridTable, gridRowContainer and then gridRow. The callback receives the row data and a few other props. Would this be an acceptable feature for a pull request?

@ryanlanciaux
Copy link
Member

That would be excellent 👍

rorykoehein pushed a commit to rorykoehein/Griddle that referenced this issue Apr 3, 2015
rorykoehein pushed a commit to rorykoehein/Griddle that referenced this issue Apr 3, 2015
rorykoehein pushed a commit to rorykoehein/Griddle that referenced this issue Apr 3, 2015
rorykoehein pushed a commit to rorykoehein/Griddle that referenced this issue Apr 3, 2015
@bpugh
Copy link
Contributor

bpugh commented Jun 23, 2015

Just checking on the status of this. @Nextminds your changes look good to me. Any reason you haven't submitted a PR?

@ryanlanciaux
Copy link
Member

All, we're closing this in favor of GriddleGriddle/griddle-render#15 that we're treating as acceptance criteria for the more modularized components that we're working towards. Please feel free to let us know of any questions 👍

@doubledherin
Copy link

I'm confused -- the Properties documentation shows onRowClick, but it seems like it's not actually implemented yet. What's the scoop?

goooseman pushed a commit to goooseman/Griddle that referenced this issue Aug 11, 2016
goooseman pushed a commit to goooseman/Griddle that referenced this issue Aug 11, 2016
goooseman pushed a commit to goooseman/Griddle that referenced this issue Aug 11, 2016
goooseman pushed a commit to goooseman/Griddle that referenced this issue Aug 11, 2016
goooseman pushed a commit to goooseman/Griddle that referenced this issue Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants