-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Initializer #757
Merged
Merged
Extract Initializer #757
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
73db68b
Enable Storybook source-map
dahlbyk 82bde75
Extract initializer util from Griddle constructor
dahlbyk 0d83e0c
Add basic initializer tests
dahlbyk 75bcb8d
Fix reducer composition for tests
dahlbyk a2a53eb
Attach individual reducers to Griddle reducer to help debugging/testing
dahlbyk df08a82
Test initialState.data
dahlbyk e48f427
Test initialState.renderProperties
dahlbyk b8e45b9
Test initialState.pageProperties
dahlbyk 9704acf
Test initialState.sortProperties
dahlbyk 4c15ac7
Test initialState.styleConfig
dahlbyk c4c6728
Test extra initialState props
dahlbyk 24f27cc
Avoid initialState key in init defaults
dahlbyk 5acfc42
Avoid special treatment for pageProperties
dahlbyk 5e6b457
Avoid special treatment for sortProperties
dahlbyk 8bff341
Test initializer reducers
dahlbyk 9eec496
Test initializer reduxMiddleware
dahlbyk bc60559
Guard against invalid props-specified reduxMiddleware
dahlbyk 1c0e5b2
Test initializer components
dahlbyk cee63fb
Test initializer settingsComponentObjects
dahlbyk 0576fbb
Test initializer events (bugs?!)
dahlbyk 3811319
Test initializer selectors
dahlbyk 764a47e
Remove unused defaultEvents
dahlbyk 5f1e8ed
Test initializer listeners
dahlbyk 227e35b
Fix deferred load setState warning
dahlbyk 3577f8f
Extract core plugin-ish
dahlbyk 1ddd84f
Handle null core
dahlbyk d2931e9
Export CorePlugin; add to types
dahlbyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the
pageProperties
andsortProperties
properties were removed. Can this be re-added?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I could/can tell, there's actually nothing special about
pageProperties
andsortProperties
relative to any other "extra" properties that are treated asinitialState
: note tests don't change in d69275a and 0cbc7d8.