Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several blocks are not protected in claims #642

Closed
NotMyFault opened this issue Oct 13, 2019 · 6 comments
Closed

Several blocks are not protected in claims #642

NotMyFault opened this issue Oct 13, 2019 · 6 comments
Labels
🐛Bug Issue is a validated bug report.
Milestone

Comments

@NotMyFault
Copy link

What happened:

I was able to edit and interact with beacons in claimed areas.

What you expected:

Beacons should be protected and only accessible with permission or trust access

Steps to reproduce:

This may include a build schematic, a video, or detailed instructions to help reconstruct the issue

  1. Setup a beacon in a claimed area
  2. Use a different account to test if you can interact with it.
    Here's a gif: https://i.gyazo.com/5fa0a0fd0fcda41feef239f9eb7af2c3.mp4

Server and GriefPrevention version:

This can be found by running /version and /version GriefPrevention on your server.
Paste of /version: This server is running Paper version git-Paper-213 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
Paste of /version GriefPrevention: GriefPrevention version 16.12.0-d4d7ac4

Stack trace/error or server log

No stacktrace.

Or, paste the server.log at gist.github.com and paste the link here:
https://gist.github.com/N0tMyFaultOG/90eaaadc9415cc919818f90891acb1e6

GriefPrevention config.yml

# Default values are perfect for most servers.  If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/
GriefPrevention:
  SeaLevelOverrides:
    world: -1
    world_nether: -1
    world_the_end: -1
  Claims:
    Mode:
      world: Survival
      world_the_end: Disabled
      world_nether: Disabled
    PreventGlobalMonsterEggs: false
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: true
    LockTrapDoors: true
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 100
    Claim Blocks Accrued Per Hour:
      Default: 50
    Max Accrued Claim Blocks:
      Default: 3000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: 4
    ExtendIntoGroundDistance: 5
    MinimumWidth: 5
    MinimumArea: 75
    MaximumDepth: 0
    InvestigationTool: STICK
    ModificationTool: GOLDEN_SHOVEL
    Expiration:
      ChestClaimDays: 7
      UnusedClaimDays: 14
      AllClaims:
        DaysInactive: 120
        ExceptWhenOwnerHasTotalClaimBlocks: 10000
        ExceptWhenOwnerHasBonusClaimBlocks: 5000
      AutomaticNatureRestoration:
        SurvivalWorlds: false
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 0
    CreationRequiresWorldGuardBuildPermission: true
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: false
    LoginCooldownSeconds: 60
    LoginLogoutNotificationsPerMinute: 5
    ChatSlashCommands: /me;/global;/local
    WhisperSlashCommands: /tell;/pm;/r;/whisper;/msg
    WarningMessage: Please reduce your noise level.  Spammers will be banned.
    BanOffenders: true
    BanMessage: Banned for spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 120
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      world: true
      world_nether: true
      world_the_end: true
    ProtectFreshSpawns: true
    PunishLogout: true
    CombatTimeoutSeconds: 60
    AllowCombatItemDrop: false
    BlockedSlashCommands: /home;/vanish;/spawn;/tpa
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: true
      AdministrativeClaims: true
      AdministrativeSubdivisions: true
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: false
  Economy:
    ClaimBlocksPurchaseCost: 0.0
    ClaimBlocksSellValue: 0.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: false
    NonPvPWorlds: true
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: true
  BlockSurfaceOtherExplosions: true
  LimitSkyTrees: true
  LimitTreeGrowth: false
  LimitPistonsToLandClaims: true
  FireSpreads: false
  FireDestroys: false
  AdminsGetWhispers: false
  AdminsGetSignNotifications: true
  SmartBan: false
  Mute New Players Using Banned Words: true
  MaxPlayersPerIpAddress: 3
  Siege:
    Worlds: []
    BreakableBlocks:
    - DIRT
    - GRASS_BLOCK
    - GRASS
    - FERN
    - DEAD_BUSH
    - COBBLESTONE
    - GRAVEL
    - SAND
    - GLASS
    - GLASS_PANE
    - OAK_PLANKS
    - SPRUCE_PLANKS
    - BIRCH_PLANKS
    - JUNGLE_PLANKS
    - ACACIA_PLANKS
    - DARK_OAK_PLANKS
    - WHITE_WOOL
    - ORANGE_WOOL
    - MAGENTA_WOOL
    - LIGHT_BLUE_WOOL
    - YELLOW_WOOL
    - LIME_WOOL
    - PINK_WOOL
    - GRAY_WOOL
    - LIGHT_GRAY_WOOL
    - CYAN_WOOL
    - PURPLE_WOOL
    - BLUE_WOOL
    - BROWN_WOOL
    - GREEN_WOOL
    - RED_WOOL
    - BLACK_WOOL
    - SNOW
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: false
  SilverfishBreakBlocks: false
  CreaturesTrampleCrops: false
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: false
  Database:
    URL: ''
    UserName: ''
    Password: ''
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 60
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: true
      Administrative Activity: false
      Debug: false
      Muted Chat Messages: false

Plugin list (if applicable):

GriefPrevention

@RoboMWM
Copy link

RoboMWM commented Oct 16, 2019

Seems something with beacons changed, even VNP spits out exceptions on it.

@RoboMWM RoboMWM added the 🐛Bug Issue is a validated bug report. label Oct 16, 2019
@NotMyFault NotMyFault changed the title Beacons are unprotected in claims Several blocks are not protected in claims Oct 16, 2019
@NotMyFault
Copy link
Author

It looks like some of the 1.14 blocks are protected where others are not.
E.g. bells, stonecutters, grindstones, cartography tables and looms are unprotected where things like barrels and smokers are protected. That's not very critical, but if people want an all round protection, all blocks should be protected rather than just some.

@RoboMWM
Copy link

RoboMWM commented Oct 16, 2019

Hmm, I guess all of these don't extend Inventory or whatever it is that the containertrust check looks for.

@RoboMWM RoboMWM added this to Backlog in Version 16 (legacy) Nov 14, 2019
@RoboMWM
Copy link

RoboMWM commented Jan 11, 2020

Ok so it seems all those blocks that aren't protected each have a special inventory but for some reason I can't find their respective blockstate... do they all not have their own blockstate? Or what is it that they inherit?

@Jikoo
Copy link
Collaborator

Jikoo commented Jan 12, 2020

Looks like blocking access to any TileState (barring lecterns, of course) would be a good way to go.

@NotMyFault
Copy link
Author

Thanks for the fix. Do you have CI where I can download it from or do I need to compile it by myself @RoboMWM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Issue is a validated bug report.
Projects
No open projects
Version 16 (legacy)
  
Delivered
Development

No branches or pull requests

3 participants