Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.15.1: BEE_NEST/BEEHIVE protection #698

Closed
wants to merge 1 commit into from

Conversation

zedwick
Copy link

@zedwick zedwick commented Jan 20, 2020

Update to 1.15.1. Prevent honey being taken from BEE_NEST and BEEHIVE using shears within other players claim. Must have container trust to access honey.

Tested in paper, but I don't foresee any issues in Spigot.

Closes #677

@RoboMWM
Copy link

RoboMWM commented Jan 20, 2020

Any drawbacks to implement this suggestion instead? #642 (comment)

Would fix a lot more rather than just chasing after these blocks.

@zedwick
Copy link
Author

zedwick commented Jan 20, 2020

Any drawbacks to implement this suggestion instead? #642 (comment)

Would fix a lot more rather than just chasing after these blocks.

I'm not sure if you can exclusively respond to legitimate interactions with all TileEntities. In this case, bee nests and beehives can only be interacted with by right clicking with shears to harvest the honey. You would be told you cannot access the block when right clicking with an empty hand or other non-interactable item. However, it might be better to be chasing after these blocks to remove unnecessary messages of over-protection, rather than leaving them unprotected until we can implement their protection.

@RoboMWM RoboMWM closed this in d7dd5a8 Jan 26, 2020
@RoboMWM
Copy link

RoboMWM commented Jan 26, 2020

I've incorporated this change (sans the item check, to keep the list simple) along with the other blocks mentioned in #642. I've decided to do it this way since that's the way the system is currently designed, but have noted using TileStates for containertrust in the v20 project.

@RoboMWM RoboMWM added this to the 16.13 milestone Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.15.1] Players can take honey from Bee nests
2 participants