Fix some more piston cases #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Retraction checked block behind piston when no blocks were moved * Everywhere modes are supposed to ignore subclaims, so piston claim should not be a subclaim
RoboMWM
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1082 - subclaims are supposed to be ignored in both
EVERYWHERE(here) andEVERYWHERE_SIMPLE(here). Unfortunately, subclaims that have been resized are added to the chunk map, so they are compared against. Technically after this PR the only required use of Claim#getOwnerID is now just the first quick check where claims may be subclaims.I'm not sure if this is enough to fix the hard-to-reproduce ailments that have been hitting
EVERYWHERE_SIMPLE, but I'm doing my best to spend a little time every so often rereading and testing.