Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block explosions damaging claimed entities #1122

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

Jikoo
Copy link
Collaborator

@Jikoo Jikoo commented Nov 29, 2020

This does not stop block explosions damaging vehicles. Unfortunately, the EntityDamageEvent only fires for living entities. The VehicleDamageEvent is lacking information required to differentiate between damage sources. If we block all entity-free damage, we'll break the age-old "run the minecart into a cactus" automatic minecart system. Maybe needs a Spigot issue opened? Not really sure. Technically may be possible with a bunch of hacky workaround tagging.

This also does not block players using block explosions to bypass PVP restrictions - it's possible, but I'm reluctant to do so until I get around to an "owner" tagging system because I would like to preserve the self-damage aspect.

This does fully address #1115, but I think either it should be left open or a new issue should be created so we can track the remaining shortcomings.

@RoboMWM RoboMWM merged commit 293142d into GriefPrevention:master Nov 29, 2020
@RoboMWM
Copy link

RoboMWM commented Nov 29, 2020

I was never a fan of labels in issues, and looking at that other one I do prefer commit messages to be just a simple english summary; active verbs make sense.

Of course I rarely label PRs, but in general the idea of the release drafter is to effectively copy the commit messages with author more or less - since this is what I do (to some extent - I do revise as needed) when I manually create a release.

@Jikoo
Copy link
Collaborator Author

Jikoo commented Nov 29, 2020

Yeah, that's what I like about release-drafter over the alternatives, the output is a lot prettier without fussing about anything. I'm just getting to the point where I feel like I'm wasting time even manually editing a version number in a script, so I'm trying to find a habit I can get to stick that'll let me automatically generate semantic versioning.

Honestly, Conventional Commits feels redundant, I may as well just label things myself based on keywords I already plan to use in the message... I just need to stop making my commit messages "whoops" when I do something extremely dumb.

I'll workshop the idea of a simple Action for semantic versioning - it might be preferable to just have a big green button on GH for releases. Could easily generate body like this, though it doesn't hit the correct GH users yet due to display names:

git log --pretty=format:"%s (%h) - @%an" $(git describe --tags --abbrev=0 @^)..@

Output for my current branch:

reinstate default of max accrual blocks to 80k (eaaa423) - @RoboMWM
Create release-drafter.yml (e8442fc) - @RoboMWM
Create release-drafter.yml (16d5a8c) - @RoboMWM
Update to current Biome API (#1044) (8465d19) - @Adam
Fix claims in other worlds preventing piston movement with EVERYWHERE_SIMPLE(#1099) (1f98733) - @Adam
Update README.md (8087dd4) - @RoboMWM
Update README.md (f5ebbc4) - @RoboMWM
Update FUNDING.yml (a22d1c1) - @RoboMWM
Create CNAME (580f009) - @RoboMWM
add chat page (00d9e16) - @RoboMWM
Piston should not be included in moved block bounding box (#1088) (8c7abf9) - @Adam
Fix incorrect retract check and everywhere modes checking subclaim (#1083) (e1086c3) - @Adam
Fix subclaims being added to chunk claims map when resized (#1082) (0ceb6f8) - @Adam
Fix restore nature removing top level of liquids (#1066) (746f104) - @FreeMonoid
Make placing and breaking boats use containertrust (#1065) (03074bf) - @FreeMonoid

@Jikoo Jikoo deleted the fix/block-explosion-damage branch November 29, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants