Fix edge cases to allow sqlite backend #1157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some non-breaking changes to DatabaseDataStore to let it work with a SQLite database. These changes make absolutely no difference with MySQL, besides no longer logging a warning the first time GP is 'installed'. For more information, see the referenced issue comment below.
Changes:
deleteSchemaVersionSQL
beingnull
. This is suppressed by MySQL, as the driver throwsSQLException
. Xerial's SQLite driver would throwNullPointerException
, which was not suppressed.;
s from SQL statements. These are pointless, and when batching, could cause problems, as MySQL driver sometimes fails to rewrite these (when rewrite enabled). Not a current concern, but regardless.Class.forName(driverName)
as this has been unnecessary since JDBC 4 - which came with Java 6!With this PR, GriefPrevention may be configured to use SQLite, using
GriefPrevention.Database.URL: jdbc:sqlite:database.db
, but I don't see this as being "proper" support for SQLite, however.Reference: #1068 (comment)