Change method signature of allowBreak method in main class

[solarrabbit99]

I'm working on a plugin, intending it to support GriefPrevention's land protection. There is this public method in the main class that caught my attention allowBreak(Player player, Block block, Location location, BlockBreakEvent breakEvent). This class takes in a Block type parameter but never utilises its properties - only calling block.getType() at some point to test if that block can be broken in a claimed area.

It is a suggestion to change the method signature to/add a method with signature allowBreak(Player player, Material material, Location location, BlockBreakEvent breakEvent) instead. This will allow plugin authors who want to know if a player can break STONE at a given location without having an actual stone there. Right now the best way to do this is to copy and paste the entire method down.

[RoboMWM]

You can also datastore#getClaimAt? But I assume you're checking for permissions too and whatnot.

[solarrabbit99]

You can also datastore#getClaimAt? But I assume you're checking for permissions too and whatnot.

Yes im checking for permissions and it seems like allowBreak() checks for wilderness too. The way I see it Material does suite more for the method, and increase the extensiveness of where the method can be applied.

[RoboMWM]

I think you can generate a block from a material but fair enough, seems like this is the only call in the plugin. Interesting.