Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop people creating nether portals in claimed land #1842

Merged
merged 2 commits into from May 25, 2022
Merged

Stop people creating nether portals in claimed land #1842

merged 2 commits into from May 25, 2022

Conversation

Elioby
Copy link

@Elioby Elioby commented Mar 24, 2022

Implemented as mentioned in #1160, stopping any player created portals from being built inside claims where they do not have the build permission.

Also added config option PreventNonPlayerCreatedPortals, which is disabled by default, which will stop any portals being created if the player who created it cannot be confirmed.

Closes #1160

Copy link
Collaborator

@Jikoo Jikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Would probably be a lot faster to use logic similar to piston handling and create a bounding box from the portal blocks, but because I didn't extract the intersection logic like a big jerk it's not super easy without a larger diff.

@RoboMWM RoboMWM added this to the 16.18.1 milestone Apr 1, 2022
Copy link

@RoboMWM RoboMWM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, wonder when this was added to that event.

Would you mind adding a section to the documentation describing this feature? https://github.com/TechFortress/GriefPrevention-Docs/blob/master/configuration.md

@Elioby
Copy link
Author

Elioby commented May 3, 2022

Added documentation in this PR: GriefPrevention/GriefPrevention-Docs#3

@RoboMWM RoboMWM merged commit d75b3cd into GriefPrevention:master May 25, 2022
@JHarris12345
Copy link

So is this being fixed in the spigot versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nether portals
4 participants