Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential NPE visualizing conflict zones #1854

Merged
merged 4 commits into from May 25, 2022
Merged

Fix potential NPE visualizing conflict zones #1854

merged 4 commits into from May 25, 2022

Conversation

Jikoo
Copy link
Collaborator

@Jikoo Jikoo commented Apr 9, 2022

  • Fix potential NPE visualizing conflict zones
    • Handle edge cases more gracefully, no result is always a failure.
  • Add error handling for external visualization providers
    • Falls through to GP's default provider so visualization is still done even if external provider is broken

Closes #1853

@RoboMWM RoboMWM merged commit c67a5d8 into GriefPrevention:master May 25, 2022
@Jikoo Jikoo deleted the fix/visualization-npe branch May 25, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoboMWM RoboMWM RoboMWM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not pass event PlayerInteractEvent to GriefPrevention v16.18-7-gf13f405
2 participants
@Jikoo @RoboMWM