Automatically update maxDepth #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minorly inconveniences users who want maxDepth to be 0. However, the majority do not want it to be 0 and do not understand that their old configurations need updating.
|
I guess this is fine, I guess my time for refactoring has been limited but I guess we'll get there, slowly, eventually, maybe. |
RoboMWM
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GriefPrevention.ConfigVersionto more easily handle config updates.This minorly inconveniences users who want
MaximumDepthto be 0 - they'll need to set it again after this. However, the vast majority of users want claims to be capable of extending to the bottom of the world and do not understand that their old configurations need updating. The support burden of dealing with that has been tremendous.