Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Datastore.getClaim(long id) to return subclaims #2011

Merged
merged 7 commits into from Mar 3, 2023

Conversation

akdukaan
Copy link

@akdukaan akdukaan commented Feb 21, 2023

Code copied from #811 which I think was closed because it tried to take on way more than just this fix

Closes #814

Code copied from GriefPrevention#811 which I think was closed because it tried to take on way more than just this fix
@akdukaan akdukaan changed the title Fix #814 Allow Datastore.getClaim(long id) to return subclaims Feb 21, 2023
@RoboMWM
Copy link

RoboMWM commented Feb 22, 2023

Looks ok, I'll see if @Jikoo has anything to add, but otherwise will pull

RoboMWM
RoboMWM previously approved these changes Feb 22, 2023
Jikoo
Jikoo previously approved these changes Feb 22, 2023
Copy link
Collaborator

@Jikoo Jikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond mixed whitespace, looks good 👍

@RoboMWM
Copy link

RoboMWM commented Feb 28, 2023

Beyond mixed whitespace, looks good 👍

Space between the ifs and fors, right? Not sure if you see elsewhere too.

@akdukaan akdukaan dismissed stale reviews from Jikoo and RoboMWM via b66c3e7 February 28, 2023 22:31
@Jikoo
Copy link
Collaborator

Jikoo commented Mar 1, 2023

Space between the ifs and fors, right? Not sure if you see elsewhere too.

I meant the mix of spaces and tabs, but you're correct, yeah.
image

@RoboMWM
Copy link

RoboMWM commented Mar 1, 2023

Space between the ifs and fors, right? Not sure if you see elsewhere too.

I meant the mix of spaces and tabs, but you're correct, yeah. image

Interesting are you viewing that in Github?

@Jikoo
Copy link
Collaborator

Jikoo commented Mar 1, 2023

Interesting are you viewing that in Github?

Browser extension, https://github.com/refined-github/refined-github
I don't like a lot of the options (and there are an unfortunate number of them for that), but showing whitespace is lovely. It's the only extension for whitespace I've found that has continued to update as GitHub breaks it over the years.

@RoboMWM RoboMWM merged commit 7bd9696 into GriefPrevention:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataStore.getClaim(long id) doesn't return subclaims
3 participants