Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command usage casing #2132

Merged
merged 1 commit into from Aug 8, 2023

Conversation

Jikoo
Copy link
Collaborator

@Jikoo Jikoo commented Aug 8, 2023

  • Fixed command usage containing capital letters
    • Mojang does not ignore case when executing commands as a part of their chat signing feature. Spigot does not ignore case when executing commands due to wanting to keep a minimal diff. Spigot always lowercases commands when registered, so GP suggesting uppercase letters in its command feedback is confusing for users.
  • Removed unused permission declarations
  • oh god the datastore had LF endings, there goes my readable diff to make sure I didn't miss anything after screwing up with a poorly-expressed replacement. Can't ignore whitespace until I make the PR. Looks okay, only sketchy-ish part is /claimslist because it uses the <command> placeholder twice and I'm not sure what replacement function Bukkit uses for that. Probably String#replace, probably fine.

Closes #1933

Removed some unused permission declarations
@RoboMWM RoboMWM merged commit dfca817 into GriefPrevention:master Aug 8, 2023
1 check passed
@Jikoo Jikoo deleted the dev/suggest-correct-case branch August 8, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caps vs lowercase commands not working
2 participants