Remove block ID usage #234
Conversation
NB AutoExtendClaimTask a bit broken
| @@ -1952,33 +1952,6 @@ else if(materialInHand == instance.config_claims_investigationTool && hand == E | |||
| return; | |||
| } | |||
|
|
|||
| //if holding a non-vanilla item | |||
| else if(Material.getMaterial(itemInHand.getTypeId()) == null) | |||
There was a problem hiding this comment.
So, getType won't return null for non-vanilla items? Just wondering since I'm sure this is here to semi-support mods (though, I'm guessing there's probably no up-to-date bukkit/forge hybrid thing out there today).
There was a problem hiding this comment.
Well Bukkit doesn’t have any way to represent non vanilla items.
Based on this code I’m assuming Cauldron was returning null for non vanilla items, but I really can’t be sure. Either way it’s not something supported via the Bukkit API
|
Bukkit doesn’t yet have an ID free snapshot method (and chunk snapshots aren’t implemented in dev builds anyway). |
|
Claim task has been fixed, requires very recent 1.12.2 though |
Also updates AutoExtendClaimTask with new API, will need to ensure users are using a recent build of CB
NB AutoExtendClaimTask a bit broken