Allow fire/lava proximity to be controlled based on world PvP rules #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So from what I understand you want to be able to control if the fire/lava placement near players applies in worlds that don't have PvP rules enabled? Because the current handling is that these features are in fact enabled for worlds that do not have PvP rules applied in config. |
|
Correct. This is to make configurable a setting that is otherwise hard-coded on, which may not necessarily be the right choice for some servers. |
|
Ok, just wanted to clarify because your original description implied GP didn't do anything at all (when it actually does). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I proposed this change because there is often a case where one does not want to explicitly allow PvP in a world, but GP's (un)handling of fire and lava placement is more of an annoyance to a server's playerbase than it helps (esp. with collaborative mob-farm building).
The old flag
GriefPrevention.PvP.AllowLavaDumpingNearOtherPlayersand it's siblingGriefPrevention.PvP.AllowFlintAndSteelNearOtherPlayersare migrated to thePvPWorldssub-flag, which should imitate previous behavior without the need for any reconfiguration.