Exempt creative/spectator gamemode from environmental PvP checks #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a first, lol. |
RoboMWM
reviewed
Jan 9, 2019
src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java
Outdated
Show resolved
Hide resolved
RoboMWM
previously approved these changes
Jan 9, 2019
|
Just thought of another thing, may want to repeat these checks for the lava placement as well. |
RoboMWM
changed the title
|
Oh, I didn’t think of that. I will try to submit another pull request
tomorrow if I have time
…On Thu, 10 Jan 2019 at 01:14, RoboMWM ***@***.***> wrote:
Just thought of another thing, may want to repeat these checks for the
lava placement as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#446 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqIQDTUShHurzZ9LDlHHY57kOUvJaiyks5vBoNDgaJpZM4Z4e4q>
.
|
|
You can include it with this one. |
|
Ok! Thanks.
…On Thu, 10 Jan 2019 at 01:27, RoboMWM ***@***.***> wrote:
You can include it with this one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#446 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqIQIbJPAW4gdsau9pujmAKuAe-22y_ks5vBojsgaJpZM4Z4e4q>
.
|
|
Brilliant, how do players figure these type of things out, always amazes me. |
|
I've noticed that there's already a check in the lava placement event to see if the player is in survival mode, so I've just added the |
RoboMWM
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vP checks
So I noticed that one of my users was randomly using flint & steel while mining. Turns out he was using it to detect when I was around spectating, because whenever I'm around, he cannot use it. (we have PvP disabled and thus GP blocks flint&steel when there's another player less than 9 blocks from your position)