Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating a whole new claim when resizing #461

Merged
merged 1 commit into from Jan 26, 2019
Merged

Avoid creating a whole new claim when resizing #461

merged 1 commit into from Jan 26, 2019

Conversation

WesternIcelander
Copy link

Copy link
Collaborator

@bigpresh bigpresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible, and simplifies the code a bit too, so I'm in favour.

My only slight concern is breaking compatibility if there's any third party code out there which uses createClaim() to set up claims automatically and could be tricked by the change of meaning of the last parameter, but I find it fairly unlikely that anyone is doing that, and documenting the change in the changelog is probably enough.

Also - I'm not sure dryRun is the best name, but I can't think of anything definitely better - saveClaim or something, maybe (with the logic negated), but that's only a really minor thing, and I don't object strongly at all :)

RoboMWM
RoboMWM previously approved these changes Jan 26, 2019
Copy link

@RoboMWM RoboMWM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. I'm guessing the isNew boolean was from @Narimm's PR.

@RoboMWM RoboMWM dismissed their stale review January 26, 2019 18:42

Found an issue I think

Copy link

@RoboMWM RoboMWM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm it's okay I guess. Unsure why result was used instead of just resaving the already-existing claim but ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants