New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/lectern #579
Fix/lectern #579
Conversation
- Allow all players to read books in lecterns - Prevent players without container trust from removing books from/placing books into lectern
Re: BlockPlaceEvent - I believe it follows the same logic as log stripping, etc. where the block's data is modified even though it isn't necessarily actually placed. I don't think it's a particularly great way to handle it, but it does at least seem somewhat consistent, though it is inconsistent with blocks like note blocks and jukeboxes. |
src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java
Outdated
Show resolved
Hide resolved
I believe I filed a bug report re: blockplaceevent. https://hub.spigotmc.org/jira/browse/SPIGOT-4387 Hmm, it's resolved as fixed. Don't recall getting an update about it. Was the PR pulled? I don't have access to see PRs. |
Looks like the PR was never pulled, its still open. |
- Changes suggested by Jikoo
src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java
Outdated
Show resolved
Hide resolved
- Changes requested by Robo
- New config option, to require access trust to read lectern books, true by default
- Changed the note as requested by Robo
src/main/java/me/ryanhamshire/GriefPrevention/GriefPrevention.java
Outdated
Show resolved
Hide resolved
- changed field name as requested by Robo
src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java
Outdated
Show resolved
Hide resolved
- Add null check for claim itself
src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java
Outdated
Show resolved
Hide resolved
- Changes as requested by zedwick
- Changes as requested by zedwick
src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java
Outdated
Show resolved
Hide resolved
- Changes as requested by Robo
- Fixed an issue with using clickedBlock.getType() throwing null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me at a glance.
References #537
NOTE:
Don't ask me why, maybe a Spigot/Bukkit mistake, but when trying to put a book into a lectern, it calls the BlockPlaceEvent (weird hey?!?)