Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 1.16 PR #866

Merged
merged 2 commits into from Jul 3, 2020
Merged

The 1.16 PR #866

merged 2 commits into from Jul 3, 2020

Conversation

isabelcoolaf
Copy link

@isabelcoolaf isabelcoolaf commented Jul 1, 2020

This probably isn't perfect so go easy on me but lmk.
It compiles and in my testing it works.

Also this fixes #865

<artifactId>bukkit</artifactId>
<version>1.15.2-R0.1-SNAPSHOT</version>
<groupId>org.spigotmc</groupId>
<artifactId>spigot-api</artifactId>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changed due to the fact SpigotMC no longer publishes Bukkit jar files and there isn't any other Bukkit Maven repo.

Source: https://www.spigotmc.org/threads/spigot-bungeecord-1-16-1.447405/

Copy link

@RoboMWM RoboMWM Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

With that, I'm sorta tempted to just set it to Paper at that rate then.

@Jikoo
Copy link
Collaborator

Jikoo commented Jul 1, 2020

Surprisingly small, is that all there was to 1.16? I guess the mounts are covered by existing event handling. Looks clean 👍

@isabelcoolaf
Copy link
Author

1.16 didn't add much in terms of plugin dev /shrug

Copy link
Collaborator

@Jikoo Jikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs api-version bump

@isabelcoolaf
Copy link
Author

Woops, good point! Fixed.

@RoboMWM
Copy link

RoboMWM commented Jul 3, 2020

small diff so that's good, else I prolly would've gone off the whole "one PR per bug fix!" mini rant

Copy link

@RoboMWM RoboMWM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kewl, thanks.

@RoboMWM RoboMWM merged commit a6a7c23 into GriefPrevention:master Jul 3, 2020
@bigpresh
Copy link
Collaborator

bigpresh commented Jul 3, 2020

Just wanted to add my thanks as well.

I've built GP with these changes and tested on my test server, and all seems to be fine, so I've just upgraded our live server to 1.16.1 with that GP build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protect Respawn Anchors in 1.16
4 participants