New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The 1.16 PR #866
The 1.16 PR #866
Conversation
<artifactId>bukkit</artifactId> | ||
<version>1.15.2-R0.1-SNAPSHOT</version> | ||
<groupId>org.spigotmc</groupId> | ||
<artifactId>spigot-api</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changed due to the fact SpigotMC no longer publishes Bukkit jar files and there isn't any other Bukkit Maven repo.
Source: https://www.spigotmc.org/threads/spigot-bungeecord-1-16-1.447405/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting.
With that, I'm sorta tempted to just set it to Paper at that rate then.
Surprisingly small, is that all there was to 1.16? I guess the mounts are covered by existing event handling. Looks clean 👍 |
1.16 didn't add much in terms of plugin dev /shrug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs api-version bump
Woops, good point! Fixed. |
small diff so that's good, else I prolly would've gone off the whole "one PR per bug fix!" mini rant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kewl, thanks.
Just wanted to add my thanks as well. I've built GP with these changes and tested on my test server, and all seems to be fine, so I've just upgraded our live server to 1.16.1 with that GP build. |
This probably isn't perfect so go easy on me but lmk.
It compiles and in my testing it works.
Also this fixes #865