-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading custom parameters in annotations #36
Conversation
this.methodName = methodName; | ||
this.className = fullClassName; | ||
this.annotations = annotations; | ||
type = (methodName == null || methodName.length() == 0) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TextUtils.isEmpty() btw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -70,7 +65,7 @@ public String getClassName() { | |||
return className; | |||
} | |||
|
|||
public List<String> getAnnotations() { | |||
public List<AnnotationInfo> getAnnotations() { | |||
return new ArrayList<>(annotations); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use Collections.unmodifiableList here
Assert.assertEquals(1, flags.size()); | ||
Assert.assertEquals("com.github.grishberg.annotaions.Feature", annotations.get(0)); | ||
Assert.assertEquals("flag1=value1", flags.get(0)); | ||
Assert.assertEquals("someParam=someValue", annotationMember.getStrValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need also tests for int, string[], int[]
Now TestPlanElement has array of list of AnnotationInfo