-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community::Prototypes does not recognize :prototype form for declaring prototypes #44
Comments
I'm not sure this is worth catching. So far, :prototype doesn't tend to be used by the target audience of this policy (newbies who think |
It would be a bit more complex to recognize, because right now it completely ignores a file using the signatures feature, as it then assumes you know what you're doing. |
I'm just hitting this issue where we enable by default function signature in most of our codebase using a custom package
|
Fix Grinnz#44 When using function signatures, prototypes can be set using the ': prototype'. With this change we can now detect explicit usage of prototype.
Fix Grinnz#44 When using function signatures, prototypes can be set using the ': prototype'. With this change we can now detect explicit usage of prototype.
foo
andbaz
get caught correctly.bat
is ignored correctly because it's an empty prototype.bar
should be caught but is not.This looks like the same problem as Perl-Critic/Perl-Critic#978
The text was updated successfully, but these errors were encountered: