Basic inotify support #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make it easier to repeatedly sync the directory when used in a daemon-like setting without reinstantiating the class
Watching a folder with inotify should be daemonized in the future pending the addition of a configuration file scheme. Some currently fixed parameters such as remote drive poll rate will also be made configurable.
|
I don't feel comfortable using inotify-tools. I read its source code and find out that it will have mutli-thread problems. As a result, 01bc438 can't be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic inotify support. A more mature implementation is pending a configuration file scheme to abstract Grive from having to be run from a particular directory. Once this is done we can easily daemonize the watch/inotify program option.