Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with React Native 0.69 #17

Closed
ammarahm-ed opened this issue Jun 29, 2022 · 3 comments
Closed

Not working with React Native 0.69 #17

ammarahm-ed opened this issue Jun 29, 2022 · 3 comments
Labels
waiting author Waiting for author response

Comments

@ammarahm-ed
Copy link

ammarahm-ed commented Jun 29, 2022

The command has stopped working after upgrading my project to RN 0.69. It seems that the property, config.project.ios.pbxprojPath has been removed from react-native.config.js. The following patch fixes this.

diff --git a/node_modules/react-native-cli-bump-version/react-native.config.js b/node_modules/react-native-cli-bump-version/react-native.config.js
index fe5274e..6197368 100644
--- a/node_modules/react-native-cli-bump-version/react-native.config.js
+++ b/node_modules/react-native-cli-bump-version/react-native.config.js
@@ -10,16 +10,14 @@ module.exports = {
                 console.log("My work here is done.");
                 return;
             }
-
             const appGradlePath = path.join(
                 config.project.android.sourceDir,
                 config.project.android.appName,
                 "build.gradle",
             );
-
             versioner({
                 root: config.root,
-                pbxprojPath: config.project.ios.pbxprojPath,
+                pbxprojPath: `${config.project.ios.sourceDir}/${config.project.ios.xcodeProject.name.replace(".xcworkspace",".xcodeproj")}/project.pbxproj`,
                 buildGradlePath: appGradlePath,
                 type: args.type,
                 semver: args.semver,
@Grohden
Copy link
Owner

Grohden commented Jun 29, 2022

@ammarahm-ed thx for reporting (and even the patch 🥇 ), I'm gonna take a look later today

@Grohden
Copy link
Owner

Grohden commented Jun 30, 2022

@ammarahm-ed, I've just released v1.5.0 with 3a5801c, let me know if that works for you!

@Grohden Grohden added the waiting author Waiting for author response label Jul 4, 2022
@ammarahm-ed
Copy link
Author

It's working. Thanks 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting author Waiting for author response
Projects
None yet
Development

No branches or pull requests

2 participants