-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warfare fixes and improvements #59
base: main
Are you sure you want to change the base?
Conversation
Everything in Warfare Alife Overhaul and Warfare Patch has been diff checked against vanilla 1.5.1.2, vanilla 1.5.2 and latest GAMMA. Including all files not changed by this patch. Individual rebase source files: * simulation_objects_props.ltx rebased on GAMMA economy. * dialogs.script rebased on Darkasleif's Stop Selling Documents. * ui_options.script rebased on GAMMA UI. This fixes several bugs and issues, most noticeably: * Many mutant smarts were capturable territories, they're hidden now. * Mutant spawns were nearly fully broken on warfare mode as a result.
For some reason the ISG start location was marked as story mode only, without any alternatives for non-story mode. This resulted in game crash on new game screen when using a non-story mode, such as warfare, due to no valid start location resulting in illegal NULL value.
Hi :) Thanks for the suggested changes ! I will run some tests with your changes before merging. The gamma economy fix is to prevent Cordon from being an open war zone with bandits in the Cordon farm, which is related to traders safety, that's why it's there. I agree it's debatable though. |
@Grokitach Thanks for checking! Let me know if you need anything or have any questions.
Ah yeah makes sense, I remember playing Anomaly some years ago and going there the first time only to find everyone's dead. For the current patch version I merged in your changes as they were so should be safe to keep as-is then. |
@Grokitach I know you've been very busy recently so perhaps it's better to more incrementally do the proposed changes, especially the load order changes proposed to make Warfare Patch smaller are likely very difficult to do. Thoughts on, as a first step, only merging this and updating the relations mod to Thanks! |
Refer to individual commit messages for the base details of changes made. The changes were tested with latest gamma in both story and story+warfare mode with a few new games. Works nicely.
Edit: Loading old warfare savegame from before these changes also works and instantly fixes the mutant spawning issue.
Further points
Some things I don't know how to modify as I don't know how GAMMA system works, there are also some things that I'd like your thoughts on first.
Regardless of any of the below, warfare is still not truly "supported" with this as it is inherently flaky, buggy and crash-prone at times (also in vanilla Anomaly). However having them enabled by default simplifies maintainership because of good conflict notifications in MO2 meaning more integrated workflow with less chance is breaking warfare mode often when editing other things. Consider this just a quality-of-life for the people that want to play warfare (like me). Good settings and mods are pre-set but be aware of bugs and crashes with no support for those if they happen.
-223- Fluid Relations - Favkis_Nexerade
should be replaced byYastin + Favkis Fluid Dynamic Relations
.user.ltx
supplied by GAMMA has correct settings for WAO. I think 1x is good as GAMMA is pretty desolate by default.Dynamic Faction Relations
system, which is off by default.Dynamic Faction Relations
setting first, or it does nothing.GAMMA Economy simulation_objects_props.ltx
Also, can you check why
G.A.M.M.A. Economy/gamedata/configs/misc/simulation_objects_props.ltx
exists? The only difference compared to vanilla anomaly 1.5.2 is the following, which is only a few stalker and bandit spawns mostly in the cordon. This seems to not belong to GAMMA economy at all?If the
simulation_objects_props.ltx
is removed from GAMMA economy it can also be removed completely from Warfare Patch and the upstream from Warfare Alife Overhaul can be used directly, much easier to maintain. For now I merged the changes made in GAMMA Economy into Warfare Patch file.Known issues
Current Warfare Alife Overhaul does not cleanly merge with survival mode (only zombie spawns). Personally I think survival mode is really gimmicky and adds no value, hence I don't see a reason to fix it.
Perhaps upstream will fix it at some point automatically? See also https://www.moddb.com/mods/stalker-anomaly/addons/warfare-alife-overhaul/page/16#comments