* locked the redis gem version #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 4 of redis gem required a higher version of redis ( Issue Grokzen#31)
|
This fix definitely seems to work. Not sure if it would be better to upgrade the Ruby version, but that's definitely a pain. Might be nice to merge this for now just to avoid the current build being broken. |
|
I noticed that there is a branch for redis 4, you/we could update ruby on that and keep a redis 3 branch and a redis 4 one. |
|
@andrei1489 @ncronquist This has now been manually committed into the master branch. Thanks for helping with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4 of redis gem required a higher version of redis ( Issue #31)