Fixed a bug where if "allowempty: True" was set inside a mapping insi…

…de a sequence it would not validate properly if no mapping keyword is set.

docs/release-notes.rst

@@ -14,6 +14,7 @@ Release Notes
  - This feature is NEW and EXPERIMENTAL in this release.
    It is now possible to specify a default rule when using a mapping.
    The rule will be used whenever no other key could be found.
+ - Fixed a bug where if allowempty was specefied in a mapping type inside a sequence type then it would not properly validate.
 
 
 1.5.2 (Nov 12, 2016)

pykwalify/core.py

@@ -323,6 +323,10 @@ def _validate_sequence(self, value, rule, path, done=None):
                     log.debug(u" * Found map inside sequence")
                     unique_keys = []
 
+                    if r.mapping is None:
+                        log.debug(u" + No rule to apply, prolly because of allowempty: True")
+                        return
+
                     for k, _rule in r.mapping.items():
                         log.debug(u" * Key: %s", k)
                         log.debug(u" * Rule: %s", _rule)

tests/files/success/40s.yaml

@@ -0,0 +1,16 @@
+data:
+    rally:
+      plugins:
+        - netcreate-boot: rally/rally-plugins/netcreate-boot 
+schema:
+    type: map
+    mapping:
+      rally:
+        type: map
+        allowempty: True
+        mapping:
+          plugins:
+            type: seq
+            sequence:
+              - type: map
+                allowempty: True

tests/test_core.py

@@ -371,6 +371,8 @@ def test_core_files(self):
             "38s.yaml",
             # Test that default mapping keyword works out of the box in a good case
             "39s.yaml",
+            # Test that allowempty works without specifying mapping keyword when used inside a sequence block
+            "40s.yaml",
         ]
 
         _fail_tests = [