Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some error message for length violations are wrong #194

Open
sdruskat opened this issue Sep 1, 2022 · 0 comments · May be fixed by #195
Open

Some error message for length violations are wrong #194

sdruskat opened this issue Sep 1, 2022 · 0 comments · May be fixed by #195

Comments

@sdruskat
Copy link

sdruskat commented Sep 1, 2022 •
edited
Loading

Environment

  • Python version: 3.10.6
  • PyKwalify version: 1.8.0 (but still in master)

Steps to Reproduce

  1. Look at lines https://github.com/Grokzen/pykwalify/blob/master/pykwalify/core.py#L892 and https://github.com/Grokzen/pykwalify/blob/master/pykwalify/core.py#L910
  2. Realize that the wording should be "less than"/"less than or equal to" rather than "greater than" for violations of min and min-ex, and "greater than or equal to" for "max ex".

Expected Behavior

  • I expect to error messages to be correct.

Observed Behavior

  • They include "greater than" for min and min-ex violations, while this is actually expected behaviour 🙂.
@sdruskat sdruskat linked a pull request Sep 1, 2022 that will close this issue
Open
sdruskat added a commit to sdruskat/pykwalifire that referenced this issue Sep 1, 2022
@sdruskat
Fix Grokzen#194: Fix error message related to string length limits
6ced6f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error message for min and min-ex violations sdruskat/pykwalifire
1 participant
@sdruskat